The following document contains the results of FindBugs Report
FindBugs Version is 1.3.2
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 1824 | 326 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Confusing to have methods com.atlassian.cache.servlet.resolver.DwrPluginContentResolver$OutputCollectingResponse.encodeRedirectUrl(String) and com.atlassian.jira.servlet.EmptyResponse.encodeRedirectURL(String) | BAD_PRACTICE | NM_CONFUSING | 367 | Low |
| Confusing to have methods com.atlassian.cache.servlet.resolver.DwrPluginContentResolver$OutputCollectingResponse.encodeURL(String) and com.atlassian.jira.servlet.EmptyResponse.encodeUrl(String) | BAD_PRACTICE | NM_CONFUSING | 346 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: com.atlassian.jira.bc.ExtendedJiraServiceContextImpl.userName | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.bc.issue.worklog.ExtendedWorklogService.getAssociatedWorklogType(GenericValue) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 146 | Low |
| Dead store to $L2 in com.atlassian.jira.bc.issue.worklog.ExtendedWorklogService.deleteWorklogType(Long) | STYLE | DLS_DEAD_LOCAL_STORE | 115 | Medium |
| Exception is caught when Exception is not thrown in com.atlassian.jira.bc.issue.worklog.ExtendedWorklogService.getWorklogUpdateDelayInDays() | STYLE | REC_CATCH_EXCEPTION | 376 | Low |
| Class com.atlassian.jira.bc.issue.worklog.ExtendedWorklogService implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 62-476 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.bc.user.search.DefaultUserGroupsPickerSearchService implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 36-87 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of com.atlassian.jira.config.DefaultExtendedConstantsManager.worklogTypes; locked 71% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.config.GradientColors.getGradientsFromColors(String, String, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of writer which is known to be null in com.atlassian.jira.export.AIssueExportManager.openWriter() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 134 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.export.RequestExportManager.writeData(Issue) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 117-119 | Medium |
| Redundant nullcheck of value, which is known to be non-null in com.atlassian.jira.export.RequestExportManager.writeData(Issue) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 129 | Medium |
| Redundant nullcheck of value, which is known to be non-null in com.atlassian.jira.export.RequestExportManager.writeData(Issue) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 135 | Medium |
| Redundant nullcheck of value, which is known to be non-null in com.atlassian.jira.export.RequestExportManager.writeData(Issue) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 131 | Low |
| Unwritten field: com.atlassian.jira.export.RequestExportManager.columnLayoutItems | CORRECTNESS | UWF_UNWRITTEN_FIELD | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: com.atlassian.jira.export.RequestHTMLExportManager.columnLayoutItems | CORRECTNESS | UWF_UNWRITTEN_FIELD | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.function.issue.FunctionHelper.cfMgr isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 26 | High |
| com.atlassian.jira.function.issue.FunctionHelper.delegator isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 28 | Low |
| com.atlassian.jira.function.issue.FunctionHelper.prjMgr isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 27 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.group.AGroupProvider.projectUserGroup should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 35 | Medium |
| Write to static field com.atlassian.jira.group.AGroupProvider.projectUserGroup from instance method com.atlassian.jira.group.AGroupProvider.retrieveGroups(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 71 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.group.DefaultGroupProvider implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 23-50 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.group.impl.CMMGroupProvider implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 26-53 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.group.impl.CMMGroupProviderFactory implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-26 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.group.impl.GroupProviderFactoryImpl implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-26 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.group.impl.GroupProviderImpl implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 26-53 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.imports.AImportManager.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 25 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to entity in com.atlassian.jira.issue.customfields.impl.AppendableExternalCFType.validateFromParams(CustomFieldParams, ErrorCollection, FieldConfig) | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| Dead store to gv in com.atlassian.jira.issue.customfields.impl.AppendableExternalCFType.validateFromParams(CustomFieldParams, ErrorCollection, FieldConfig) | STYLE | DLS_DEAD_LOCAL_STORE | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to gv in com.atlassian.jira.issue.customfields.impl.ExternalCFType.validateFromParams(CustomFieldParams, ErrorCollection, FieldConfig) | STYLE | DLS_DEAD_LOCAL_STORE | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to wA in com.atlassian.jira.issue.customfields.impl.WorklogCFType.validateFromParams(CustomFieldParams, ErrorCollection, FieldConfig) | STYLE | DLS_DEAD_LOCAL_STORE | 70 | Medium |
| Private method com.atlassian.jira.issue.customfields.impl.WorklogCFType.getRoleLevels(GenericValue) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 121-131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.link.CreateAndLinkIssueHelper.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 39 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.search.FilterFactory.filterHelper should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Low |
| Write to static field com.atlassian.jira.issue.search.FilterFactory.filterHelper from instance method new com.atlassian.jira.issue.search.FilterFactory(SearchRequestManager, ProjectManager) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.issue.search.FilterHelper.instance in com.atlassian.jira.issue.search.FilterHelper.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 42-43 | Low |
| Unread field: com.atlassian.jira.issue.search.FilterHelper.author | PERFORMANCE | URF_UNREAD_FIELD | 38 | Medium |
| Unread field: com.atlassian.jira.issue.search.FilterHelper.log | PERFORMANCE | URF_UNREAD_FIELD | 32 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.issue.search.parameters.filter.WorkPermissionsParameter implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 29-45 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in com.atlassian.jira.issue.search.parameters.filter.WorkedRetentionIssueFilter.filterIssue(GenericValue) | STYLE | UCF_USELESS_CONTROL_FLOW | 71 | Low |
| Unread field: com.atlassian.jira.issue.search.parameters.filter.WorkedRetentionIssueFilter.workerManager | PERFORMANCE | URF_UNREAD_FIELD | 31 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.status.RemovedStatusImpl defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 101 | Medium |
| Confusing to have methods com.atlassian.jira.issue.status.RemovedStatusImpl.setIconUrl(String) and com.atlassian.jira.util.entities.IssueEntity.setIconURL(String) | BAD_PRACTICE | NM_CONFUSING | 85 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.workers.DefaultWorkerManager.isWorkingOn(User, GenericValue) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 128 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.worklog.ExtendedWorklog defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 53-58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: com.atlassian.jira.issue.worklog.WorklogAttributes.groupLevel | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Unused field: com.atlassian.jira.issue.worklog.WorklogAttributes.roleLevelId | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.issue.worklog.WorklogHelper.hasRequiredPermissions(GenericValue, User, String) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 144-146 | Medium |
| Dead store to worklogActions in com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(Map) | STYLE | DLS_DEAD_LOCAL_STORE | 510 | Medium |
| Dead store to newTime in com.atlassian.jira.issue.worklog.WorklogHelper.adjustIssueField(GenericValue, String, long, List) | STYLE | DLS_DEAD_LOCAL_STORE | 857 | Low |
| Dead store to hasRequiredPermissions in com.atlassian.jira.issue.worklog.WorklogHelper.hasRequiredPermissions(GenericValue, User, String) | STYLE | DLS_DEAD_LOCAL_STORE | 141 | Low |
| Should com.atlassian.jira.issue.worklog.WorklogHelper.transformIssuesToLongIds(Collection) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 1007 | Low |
| Redundant nullcheck of worklogs, which is known to be non-null in com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(GenericValue, User) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 196 | Low |
| Redundant nullcheck of _after which is known to be null in com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 493 | Medium |
| Redundant nullcheck of _issues which is known to be null in com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 498 | Medium |
| Redundant nullcheck of _user which is known to be null in com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(Map) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 488 | Medium |
| Private method com.atlassian.jira.issue.worklog.WorklogHelper.getWorklogs(Map) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 475-516 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.worklog.WorklogHelper$1 defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 698 | Medium |
| The class com.atlassian.jira.issue.worklog.WorklogHelper$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 692-698 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.issue.worklogtype.NotDefinedWorklogType defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 113 | Medium |
| Confusing to have methods com.atlassian.jira.issue.worklogtype.NotDefinedWorklogType.getIconUrl() and com.atlassian.jira.util.entities.IssueEntity.getIconURL() | BAD_PRACTICE | NM_CONFUSING | 47 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.jelly.tag.AddNotifiableFields.notifiableUpdateManager in com.atlassian.jira.jelly.tag.AddNotifiableFields.getNotifiableUpdateManager() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 102-103 | Low |
| Incorrect lazy initialization of static field com.atlassian.jira.jelly.tag.AddNotifiableFields.projectManager in com.atlassian.jira.jelly.tag.AddNotifiableFields.getProjectManager() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 109-110 | Low |
| com.atlassian.jira.jelly.tag.AddNotifiableFields.notifiableUpdateManager should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| com.atlassian.jira.jelly.tag.AddNotifiableFields.projectManager should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in com.atlassian.jira.jelly.tag.ManageUpgrade.doTag(XMLOutput) | STYLE | REC_CATCH_EXCEPTION | 45 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ?, which is known to be non-null in com.atlassian.jira.jelly.tag.MigrateProject.doTag(XMLOutput) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 39 | Low |
| Exception is caught when Exception is not thrown in com.atlassian.jira.jelly.tag.MigrateProject.doTag(XMLOutput) | STYLE | REC_CATCH_EXCEPTION | 44 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.jelly.tag.ValidationHelper.outlookDate in com.atlassian.jira.jelly.tag.ValidationHelper.getLocalizedLongDateFormat(Locale) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 41-42 | Low |
| Incorrect lazy initialization of static field com.atlassian.jira.jelly.tag.ValidationHelper.outlookDate in com.atlassian.jira.jelly.tag.ValidationHelper.getLocalizedShortDateFormat(Locale) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 29-30 | Low |
| Call to method of static java.text.DateFormat in com.atlassian.jira.jelly.tag.ValidationHelper.getLocalizedLongDate(Locale, String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 56 | Medium |
| Call to method of static java.text.DateFormat in com.atlassian.jira.jelly.tag.ValidationHelper.getLocalizedShortDate(Locale, String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 66 | Medium |
| Found static field of type java.text.DateFormat in com.atlassian.jira.jelly.tag.ValidationHelper.ISO8601LongDateFormat | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE | Not available | Medium |
| Found static field of type java.text.DateFormat in com.atlassian.jira.jelly.tag.ValidationHelper.ISO8601ShortDateFormat | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| TranslateConstant.issueConstant not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| TranslateConstant.parent not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.MakeConditionHelper.instance in com.atlassian.jira.plugin.MakeConditionHelper.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 36-37 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.issueoperation.ExtendedIssueOperationModuleDescriptor.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.plugin.issueoperation.ExtendedIssueOperationModuleDescriptor$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 45-48 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.issueoperation.LinkerIssueOperationModuleDescriptor.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 27 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.issuetabpanel.WorklogTabPanel.DEFAULT_REPORT_KEY isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 54 | High |
| com.atlassian.jira.plugin.issuetabpanel.WorklogTabPanel.i18nLocations isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 | High |
| com.atlassian.jira.plugin.issuetabpanel.WorklogTabPanel.WORKLOG_COOKIE_NAME isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 53 | Low |
| Class com.atlassian.jira.plugin.issuetabpanel.WorklogTabPanel implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 46-153 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.JiraUrlBase should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.projectManager should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.customFieldManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 53 | High |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.userManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 | High |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.worklogHelper isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 52 | High |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.hoursPerDay isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 64 | Medium |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.secondsInDay isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 66 | Medium |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.daysPerWeek isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 65 | Low |
| com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.issueManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 51 | Low |
| The field name com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.JiraUrlBase doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| Write to static field com.atlassian.jira.plugin.report.AbstractIssueBeanHelper.projectManager from instance method new com.atlassian.jira.plugin.report.AbstractIssueBeanHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 70 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.report.DefaultIssueBeanHelper.instance in com.atlassian.jira.plugin.report.DefaultIssueBeanHelper.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 22-23 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in com.atlassian.jira.plugin.report.issue.AIssueReport.generateReportHtml(ProjectActionSupport, Map) passes null for unconditionally dereferenced parameter of performAgregation(AGroupData, List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 108 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to key in com.atlassian.jira.plugin.report.issue.AIssueReport$2.translate(String, AGroupData) | STYLE | DLS_DEAD_LOCAL_STORE | 314 | Medium |
| Dead store to name in com.atlassian.jira.plugin.report.issue.AIssueReport$2.translate(String, AGroupData) | STYLE | DLS_DEAD_LOCAL_STORE | 315 | Medium |
| The class com.atlassian.jira.plugin.report.issue.AIssueReport$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 279-375 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.plugin.report.issue.AIssueReport$3 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 395-396 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from fr.kaamelot.reporter.AGroupData to com.atlassian.jira.plugin.report.issue.IssueGroupData in new com.atlassian.jira.plugin.report.issue.IssueGroupData(String, AGroupData) | STYLE | BC_UNCONFIRMED_CAST | 13 | Low |
| Useless control flow in com.atlassian.jira.plugin.report.issue.IssueGroupData.evaluateData(IMappable) | STYLE | UCF_USELESS_CONTROL_FLOW | 17 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.report.provider.AReportDefinitionProvider.applicationProperties isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 51 | High |
| com.atlassian.jira.plugin.report.provider.AReportDefinitionProvider.customFieldManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Confusing to have methods com.atlassian.jira.plugin.report.provider.ReportDefinition.getkey() and com.atlassian.jira.plugin.report.provider.ReportElement.getKey() | BAD_PRACTICE | NM_CONFUSING | 61 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.report.provider.ReportElementOnCustomField.customFieldManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 32 | High |
| com.atlassian.jira.plugin.report.provider.ReportElementOnCustomField.issueManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | Low |
| Redundant nullcheck of _value, which is known to be non-null in com.atlassian.jira.plugin.report.provider.ReportElementOnCustomField.getStringFromValue(CustomFieldType, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 122 | Low |
| Redundant nullcheck of _value, which is known to be non-null in com.atlassian.jira.plugin.report.provider.ReportElementOnCustomField.getValueFromCustomfieldObject(CustomFieldType, Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 201 | Low |
| Unread field: com.atlassian.jira.plugin.report.provider.ReportElementOnCustomField.log | PERFORMANCE | URF_UNREAD_FIELD | 30 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.report.provider.ReportElementOnLinkedEntity.issueManager should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| Write to static field com.atlassian.jira.plugin.report.provider.ReportElementOnLinkedEntity.issueManager from instance method new com.atlassian.jira.plugin.report.provider.ReportElementOnLinkedEntity(String, String, String, Class) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 38 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.plugin.report.stats.StatsTranstionReport.i18nLocations isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 46 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from fr.kaamelot.reporter.AGroupData to com.atlassian.jira.plugin.report.workload.WorkloadByIssueTypeGroupData in new com.atlassian.jira.plugin.report.workload.WorkloadByIssueTypeGroupData(String, AGroupData) | STYLE | BC_UNCONFIRMED_CAST | 45 | Low |
| com.atlassian.jira.plugin.report.workload.WorkloadByIssueTypeGroupData.ALL_ISSUE_TYPES isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 27 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from fr.kaamelot.reporter.AGroupData to com.atlassian.jira.plugin.report.workload.WorkloadByWorklogTypeGroupData in new com.atlassian.jira.plugin.report.workload.WorkloadByWorklogTypeGroupData(String, AGroupData) | STYLE | BC_UNCONFIRMED_CAST | 53 | Low |
| com.atlassian.jira.plugin.report.workload.WorkloadByWorklogTypeGroupData.ALL_WORKLOG_TYPES isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 29 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to realField in com.atlassian.jira.plugin.report.workload.WorkloadHelper.getAddedExpr(ReportElement, Map, Map) | STYLE | DLS_DEAD_LOCAL_STORE | 389 | Medium |
| com.atlassian.jira.plugin.report.workload.WorkloadHelper.getFilteredWorkLogs(User, ReportDefinition, Map, Map) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 344 | Medium |
| Suspicious comparison of java.lang.Boolean references in com.atlassian.jira.plugin.report.workload.WorkloadHelper.getFilteredWorkLogs(User, ReportDefinition, Map, Map) | BAD_PRACTICE | RC_REF_COMPARISON | 356 | Medium |
| Method com.atlassian.jira.plugin.report.workload.WorkloadHelper.getAddedExprs(Map, Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 376 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.plugin.report.workload.WorkloadHelper$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 447-496 | Low |
| Method com.atlassian.jira.plugin.report.workload.WorkloadHelper$1.getPath(IMappable) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 458 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.plugin.report.workload.WorkloadHelper$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 534-535 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field WorkloadIssueType.workloadHelper masks field in superclass com.atlassian.jira.plugin.report.workload.AWorkloadReport | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.plugin.report.workload.WorkloadNameTranslator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 19-20 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field WorkloadProject.workloadHelper masks field in superclass com.atlassian.jira.plugin.report.workload.AWorkloadReport | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from fr.kaamelot.reporter.AGroupData to com.atlassian.jira.plugin.report.workload.WorkloadProjectGroupData in new com.atlassian.jira.plugin.report.workload.WorkloadProjectGroupData(String, AGroupData) | STYLE | BC_UNCONFIRMED_CAST | 101 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should com.atlassian.jira.plugin.report.workload.WorkloadProjectGroupData$TimeDetails be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 39-71 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field WorkloadWorklogType.workloadHelper masks field in superclass com.atlassian.jira.plugin.report.workload.AWorkloadReport | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.report.workload.provider.WorkloadIssuePanelReportDefinitionProvider.instance in com.atlassian.jira.plugin.report.workload.provider.WorkloadIssuePanelReportDefinitionProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 25-26 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.report.workload.provider.WorkloadIssueReportDefinitionProvider.instance in com.atlassian.jira.plugin.report.workload.provider.WorkloadIssueReportDefinitionProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 26-27 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.report.workload.provider.WorkloadProjectReportDefinitionProvider.instance in com.atlassian.jira.plugin.report.workload.provider.WorkloadProjectReportDefinitionProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 28-29 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.plugin.report.workload.provider.WorkloadReportDefinitionProvider.instance in com.atlassian.jira.plugin.report.workload.provider.WorkloadReportDefinitionProvider.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 61-62 | Low |
| com.atlassian.jira.plugin.report.workload.provider.WorkloadReportDefinitionProvider.applicationProperties isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 | High |
| com.atlassian.jira.plugin.report.workload.provider.WorkloadReportDefinitionProvider.customFieldManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
| Class com.atlassian.jira.plugin.report.workload.provider.WorkloadReportDefinitionProvider implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 46-148 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ProjectGroupAdminTabPanel.browser not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.plugins.projectpanel.admin.ProjectGroupAdminTabPanel$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 105-107 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.portal.AutoTransitionServiceSearcherValuesGenerator.applicationProperties isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 30 | High |
| com.atlassian.jira.portal.AutoTransitionServiceSearcherValuesGenerator.userManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 32 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.portal.CandidateProjectCategoryValuesGenerator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-42 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.portal.CandidateProjectsValuesGenerator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 26-46 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.portal.CandidateSearchRequestValuesGenerator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 16-24 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.portal.ProjectsValuesGenerator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-32 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.portal.SearchRequestFromServiceValuesGenerator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-37 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.portal.portlets.FastWorklogPortlet.getWorkedIssues(User, long, String, boolean) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 317-318 | Medium |
| Method com.atlassian.jira.portal.portlets.FastWorklogPortlet.getWorkedIssuesComparator(String, boolean) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 282-283 | Medium |
| com.atlassian.jira.portal.portlets.FastWorklogPortlet.getVelocityDedicatedPortletParams(PortletConfiguration) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.portal.portlets.FastWorklogPortlet doesn't override com.atlassian.jira.portal.PortletImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 216-225 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of retentionTime in com.atlassian.jira.portal.portlets.FastWorklogPortlet.getVelocityDedicatedPortletParams(PortletConfiguration) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 127 | High |
| Possible null pointer dereference of worklogHistory in com.atlassian.jira.portal.portlets.FastWorklogPortlet.getVelocityDedicatedPortletParams(PortletConfiguration) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 144 | High |
| Questionable use of non-short-circuit logic in com.atlassian.jira.portal.portlets.FastWorklogPortlet.getVelocityDedicatedPortletParams(PortletConfiguration) | STYLE | NS_NON_SHORT_CIRCUIT | 127 | Low |
| Questionable use of non-short-circuit logic in com.atlassian.jira.portal.portlets.FastWorklogPortlet.getVelocityDedicatedPortletParams(PortletConfiguration) | STYLE | NS_NON_SHORT_CIRCUIT | 144 | Low |
| Private method com.atlassian.jira.portal.portlets.FastWorklogPortlet.getWorkedIssues(User, long, String, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 304-329 | Low |
| Unread field: com.atlassian.jira.portal.portlets.FastWorklogPortlet.sortOrder | PERFORMANCE | URF_UNREAD_FIELD | 75 | Medium |
| Unread field: com.atlassian.jira.portal.portlets.FastWorklogPortlet.issueFactory | PERFORMANCE | URF_UNREAD_FIELD | 101 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.portal.portlets.FastWorklogPortletOnRequest doesn't override com.atlassian.jira.portal.PortletImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 216-225 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of worklogHistory in com.atlassian.jira.portal.portlets.FastWorklogPortletOnRequest.getVelocityDedicatedPortletParams(PortletConfiguration) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 72 | High |
| Questionable use of non-short-circuit logic in com.atlassian.jira.portal.portlets.FastWorklogPortletOnRequest.getVelocityDedicatedPortletParams(PortletConfiguration) | STYLE | NS_NON_SHORT_CIRCUIT | 72 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.portal.portlets.FragmentPortlet doesn't override com.atlassian.jira.portal.PortletImpl.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 216-225 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.project.AAdminProjectManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 100-103 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Abstract com.atlassian.jira.referentiel.entities.AExternalEntity defines equals(AExternalEntity) method | BAD_PRACTICE | EQ_ABSTRACT_SELF | 23-148 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.referentiel.entities.AInternalEntity.addKeys(Map) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 43 | Medium |
| Exception is caught when Exception is not thrown in com.atlassian.jira.referentiel.entities.AInternalEntity.addKeys(Map) | STYLE | REC_CATCH_EXCEPTION | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.scheduler.JiraAddOnSchedulerLauncher implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 9-16 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.security.CustomPermissions.CUSTOM_PERMISSIONS_BASE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 8 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.service.AutoTransitionService.CATEGORY_KEY isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 | High |
| com.atlassian.jira.service.AutoTransitionService.PROJECT_KEY isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 35 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.service.services.export.RollOverExportService.run() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 111 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.service.services.export.RollOverExportService$1 defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 160 | Medium |
| The class com.atlassian.jira.service.services.export.RollOverExportService$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 156-160 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 226 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.servlet.CSSVelocityPluginRessourceResolver.getVelocityParameters(String, HttpServletRequest, HttpServletResponse) needlessly instantiates a class that only supplies static methods | BAD_PRACTICE | ISC_INSTANTIATE_STATIC_CLASS | 17 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in new com.atlassian.jira.servlet.CharResponseWrapper(ServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 42 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.servlet.DWRServlet.urlPivot extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 51 | Low |
| Class com.atlassian.jira.servlet.DWRServlet.urlPivot extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 59 | Low |
| The class name com.atlassian.jira.servlet.DWRServlet shadows the simple name of the superclass uk.ltd.getahead.dwr.DWRServlet | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 41-147 | High |
| Redundant nullcheck of in, which is known to be non-null in com.atlassian.jira.servlet.DWRServlet.readFile(String, Configuration) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 101 | Low |
| Class com.atlassian.jira.servlet.DWRServlet defines non-transient non-serializable instance field pluginAccessor | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.servlet.DWRServlet$MockRequest implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 135-144 | Low |
| Should com.atlassian.jira.servlet.DWRServlet$MockRequest be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 135-144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.servlet.DWRServlet$MockResponse implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 130 | Low |
| Should com.atlassian.jira.servlet.DWRServlet$MockResponse be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should com.atlassian.jira.servlet.EmptyRequest.getCookies() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 45 | Low |
| Should com.atlassian.jira.servlet.EmptyRequest.getParameterValues(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 215 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.servlet.VelocityPluginRessourceResolver$MockRequest implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 111-120 | Low |
| Should com.atlassian.jira.servlet.VelocityPluginRessourceResolver$MockRequest be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 111-120 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.upgrade.AAddOnUpgradeManager.addAllUpgrades(Map, String) directly allocates a specific implementation of xml interfaces | STYLE | XFB_XML_FACTORY_BYPASS | 110 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.upgrade.tasks.UpgradeTask_Build_1 implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 32-73 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to l in com.atlassian.jira.util.DateTools.getDurationShortStringSeconds(long, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 280 | Low |
| Result of integer multiplication cast to long in com.atlassian.jira.util.DateTools.getNiceTimeDuration(long) | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 226 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 190 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.util.entities.EntitiesHelper.instance in com.atlassian.jira.util.entities.EntitiesHelper.getInstance() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 105-106 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.constantsManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 93 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.customFieldManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 90 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.customFieldValidator from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 91 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.eventTypeManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 98 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.fieldConfigSchemeManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 96 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.fieldScreenManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 94 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.issueTypeSchemeManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 97 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.optionSetManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 99 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.optionsManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 89 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.projectManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 92 | Low |
| Write to static field com.atlassian.jira.util.entities.EntitiesHelper.treeManager from instance method new com.atlassian.jira.util.entities.EntitiesHelper() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 95 | Low |
| Unread field: com.atlassian.jira.util.entities.EntitiesHelper.customFieldValidator | PERFORMANCE | URF_UNREAD_FIELD | 91 | Low |
| Unread field: com.atlassian.jira.util.entities.EntitiesHelper.fieldConfigSchemeManager | PERFORMANCE | URF_UNREAD_FIELD | 96 | Low |
| Unread field: com.atlassian.jira.util.entities.EntitiesHelper.fieldScreenManager | PERFORMANCE | URF_UNREAD_FIELD | 94 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in com.atlassian.jira.util.entities.Entity.store() | STYLE | REC_CATCH_EXCEPTION | 74 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: com.atlassian.jira.util.entities.SequencedEntity.sequence | PERFORMANCE | URF_UNREAD_FIELD | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.IconPickerAddOn defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| com.atlassian.jira.web.action.admin.IconPickerAddOn is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 19-54 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.AddScheme defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.CopyScheme defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.DeleteScheme defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.EditLinkSchemeEntities defines non-transient non-serializable instance field issueLinkType | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.link.scheme.EditLinkSchemeEntities defines non-transient non-serializable instance field issueLinkTypeManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.link.scheme.EditLinkSchemeEntities defines non-transient non-serializable instance field linkSchemeHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Useless control flow in com.atlassian.jira.web.action.admin.link.scheme.EditLinkSchemeEntities.doAddSchemeEntityValidation() | STYLE | UCF_USELESS_CONTROL_FLOW | 89 | Low |
| EditLinkSchemeEntities.linkDesc not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.EditScheme defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.SchemeLinkAwareAction defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.SelectScheme defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.link.scheme.ViewSchemes defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.manageable.ManageableAsProjectBrowser defines non-transient non-serializable instance field manageableAsProjectManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field com.atlassian.jira.web.action.admin.plugins.settings.EditPluginsSettings.editableParam in com.atlassian.jira.web.action.admin.plugins.settings.EditPluginsSettings.getEditableParam() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 92-93 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.plugins.settings.ViewPluginsSettings defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.plugins.settings.ViewPluginsSettings defines non-transient non-serializable instance field settingsProviderDirectory | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 100 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.translation.ViewAddOnTranslations defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.worklogtypes.DeleteWorklogType defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.worklogtypes.DeleteWorklogType defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.worklogtypes.DeleteWorklogType defines non-transient non-serializable instance field worklogHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.worklogtypes.EditWorklogType defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.admin.worklogtypes.EditWorklogType defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.admin.worklogtypes.ViewWorklogTypes defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store of null to linkSchemeEntity in com.atlassian.jira.web.action.issue.CreateAndLinkIssue.getLinkSchemeEntity() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 111 | Low |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field createAndLinkIssueHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field issueLinkTypeManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field linkCollection | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field linkSchemeEntity | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field linkSchemeHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field linkSchemeManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateAndLinkIssue defines non-transient non-serializable instance field targetIssue | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| com.atlassian.jira.issue.MutableIssue stored into non-transient field CreateAndLinkIssue.targetIssue | BAD_PRACTICE | SE_BAD_FIELD_STORE | 131 | Medium |
| com.atlassian.jira.issue.MutableIssue stored into non-transient field CreateAndLinkIssue.targetIssue | BAD_PRACTICE | SE_BAD_FIELD_STORE | 136 | Medium |
| CreateAndLinkIssue.targetIssue not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field fieldManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field issueFactory | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field issueLinkManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field issueLinkedCreationHelperBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field originalIssue | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.CreateLinkedIssue defines non-transient non-serializable instance field permissionManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.web.action.issue.EditIssueWorkLog.addFields(Map, EditIssueWorkLog) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 145-146 | Medium |
| Class com.atlassian.jira.web.action.issue.EditIssueWorkLog defines non-transient non-serializable instance field extendedConstantsManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.EditIssueWorkLog defines non-transient non-serializable instance field i18nBean | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.EditIssueWorkLog defines non-transient non-serializable instance field worklog | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.EditIssueWorkLog defines non-transient non-serializable instance field worklogHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.EditIssueWorkLog defines non-transient non-serializable instance field worklogService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to redirect in com.atlassian.jira.web.action.issue.ExtendedCreateWorklog.doExecute() | STYLE | DLS_DEAD_LOCAL_STORE | 66 | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklog defines non-transient non-serializable instance field adminProjectManagerDirectory | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklog defines non-transient non-serializable instance field workerManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklog defines non-transient non-serializable instance field worklogHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklog defines non-transient non-serializable instance field worklogManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklog defines non-transient non-serializable instance field worklogService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklogForAjax defines non-transient non-serializable instance field actionWorklogHelperForAjax | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedCreateWorklogForAjax defines non-transient non-serializable instance field permissionManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to redirect in com.atlassian.jira.web.action.issue.ExtendedDeleteWorklog.doExecute() | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedDeleteWorklog defines non-transient non-serializable instance field workerManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedDeleteWorklog defines non-transient non-serializable instance field worklogHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedDeleteWorklog defines non-transient non-serializable instance field worklogService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.ExtendedDeleteWorklogForAjax defines non-transient non-serializable instance field actionWorklogHelperForAjax | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.ExtendedEditIssue defines non-transient non-serializable instance field issueFactory | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to redirect in com.atlassian.jira.web.action.issue.ExtendedUpdateWorklog.doExecute() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedUpdateWorklog defines non-transient non-serializable instance field issueWorklog | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedUpdateWorklog defines non-transient non-serializable instance field worklogHelper | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ExtendedUpdateWorklog defines non-transient non-serializable instance field worklogService | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.ExtendedUpdateWorklogForAjax defines non-transient non-serializable instance field actionWorklogHelperForAjax | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.HackedCreateWorklog defines non-transient non-serializable instance field worklog | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.action.issue.ManageWorkers defines non-transient non-serializable instance field issueManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.jira.web.action.issue.ManageWorkers defines non-transient non-serializable instance field workerManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.web.action.issue.ViewIssueAddOn is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-34 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.web.bean.ManageableAsProjectFilter defines non-transient non-serializable instance field manageableAsProjectManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 49 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.workflow.ExtendedWorkflowManager.isDeletable(Issue) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 174 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.workflow.WorkflowTransitionUtilAddOnImpl.UNCHANGED_VALUE_FIELD isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 32 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.workflow.condition.ActivityCondition.commentManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 | High |
| com.atlassian.jira.workflow.condition.ActivityCondition.transitionManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 47 | High |
| com.atlassian.jira.workflow.condition.ActivityCondition.worklogManager isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
| Null pointer dereference of entry in com.atlassian.jira.workflow.condition.ActivityCondition.getTransitions(Map) | CORRECTNESS | NP_ALWAYS_NULL | 111 | High |
| Load of known null value in com.atlassian.jira.workflow.condition.ActivityCondition.getTransitions(Map) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 111 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.condition.AllowEstimateNotNull implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 18-24 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.workflow.condition.WorkableIssueCondition.worklogService isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 22 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.condition.group.AllowCategoryManagers implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 25-35 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.condition.group.AllowProjectDeveloppers implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-24 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.condition.group.AllowProjectManagers implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-24 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.condition.group.AllowProjectUsers implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 22-25 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.workflow.function.AInheritFromParentFunction.storeModifiedFields(MutableIssue) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.atlassian.jira.workflow.function.ATransitionFunction.fieldScreenRendererFactory isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 60 | High |
| Exception is caught when Exception is not thrown in com.atlassian.jira.workflow.function.ATransitionFunction.getFieldScreen(ActionDescriptor) | STYLE | REC_CATCH_EXCEPTION | 122 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.InheritAffectedVersionsFunction implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 7-14 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.InheritComponentsFunction implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 7-14 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.InheritFixVersionsFunction implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 7-14 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.InheritPriorityFunction implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 7-11 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field PropagateAffectedVersionToSubTask.versionManager masks field in superclass com.atlassian.jira.workflow.function.APropagateVersion | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.issue.StartWorkingFunctionProvider implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 23-52 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.function.issue.StopWorkingFunctionProvider implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 22-51 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.atlassian.jira.workflow.transition.DefaultTransitionManager.getTransitionSummary(Issue) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 85 | Medium |
| com.atlassian.jira.workflow.transition.DefaultTransitionManager.WF_CURRENT_STEP isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | High |
| com.atlassian.jira.workflow.transition.DefaultTransitionManager.WF_HISTORY_STEP isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 36 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.atlassian.jira.workflow.transition.DefaultTransitionManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 126-129 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Transition.changedAt not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.jira.workflow.validator.CombinedValidator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-78 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to worklog in com.atlassian.jira.workflow.validator.WorkableIssueValidator.doValidate(Map, Map, PropertySet) | STYLE | DLS_DEAD_LOCAL_STORE | 67 | Low |
| Class com.atlassian.jira.workflow.validator.WorkableIssueValidator implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 33-165 | Low |
| Method com.atlassian.jira.workflow.validator.WorkableIssueValidator.doValidate(Map, Map, PropertySet) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 54 | Medium |
| Method com.atlassian.jira.workflow.validator.WorkableIssueValidator.doValidate(Map, Map, PropertySet) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.atlassian.servlet.CombinedServlet.contentByResolver extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 138 | Low |
| Class com.atlassian.servlet.CombinedServlet.contentResolvers extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 174 | Low |
| Class com.atlassian.servlet.CombinedServlet.contentType extends Servlet class and uses instance variables | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 197 | Low |
| Exception is caught when Exception is not thrown in com.atlassian.servlet.CombinedServlet.getObjectForClass(String) | STYLE | REC_CATCH_EXCEPTION | 222 | Low |
| Class com.atlassian.servlet.CombinedServlet defines non-transient non-serializable instance field cacheExpirationHandler | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class com.atlassian.servlet.CombinedServlet defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method fr.kaamelot.reporter.AGroupData.hasData() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 132 | Low |
