PMD Results

The following document contains the results of PMD 4.2.2.

Files

com/atlassian/jira/bc/issue/worklog/ExtendedWorklogService.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.exception.PermissionException' 25
Avoid unused imports such as 'com.atlassian.jira.security.JiraAuthenticationContext' 36
Avoid unused imports such as 'com.atlassian.jira.util.ErrorCollection' 41
Avoid unused local variables such as 'i'. 115
Avoid empty catch blocks 116 - 118
Avoid empty catch blocks 146 - 147
Avoid empty catch blocks 376 - 377
These nested if statements could be combined 428 - 430

com/atlassian/jira/config/GradientColors.java

Violation Line
An empty statement (semicolon) not part of a loop 56

com/atlassian/jira/config/settings/managers/IntegerSettingManager.java

Violation Line
Avoid empty catch blocks 38 - 39

com/atlassian/jira/export/AIssueExportManager.java

Violation Line
Avoid unused private fields such as 'DEFAULT_DATE_FORMAT'. 24

com/atlassian/jira/export/RequestExportManager.java

Violation Line
Avoid unused private fields such as 'log'. 44

com/atlassian/jira/export/RequestHTMLExportManager.java

Violation Line
Avoid unused private fields such as 'log'. 31

com/atlassian/jira/group/IGroupSchemeManager.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.scheme.AbstractSchemeManager' 8

com/atlassian/jira/issue/action/GenericAction.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.plugin.JiraResourcedModuleDescriptor' 11
Avoid unused constructor parameters such as 'remoteUser'. 30 - 33

com/atlassian/jira/issue/action/GenericResourceAction.java

Violation Line
Avoid unused imports such as 'java.sql.Timestamp' 3
Avoid unused imports such as 'com.opensymphony.user.User' 11

com/atlassian/jira/issue/customfields/impl/AppendableExternalCFType.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.upgrade.IAddOnUpgradeManager' 23
Avoid unused local variables such as 'gv'. 55
Avoid unused local variables such as 'entity'. 64

com/atlassian/jira/issue/customfields/impl/ExternalCFType.java

Violation Line
Avoid unused local variables such as 'gv'. 73

com/atlassian/jira/issue/customfields/impl/ManageableAsProjectCFType.java

Violation Line
Avoid unused imports such as 'java.util.ArrayList' 3
Avoid unused imports such as 'java.util.List' 5

com/atlassian/jira/issue/customfields/impl/WorklogCFType.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.config.ConstantsManager' 13
Avoid unused imports such as 'com.atlassian.jira.issue.fields.renderer.RenderableField' 21
Avoid unused local variables such as 'wA'. 68

com/atlassian/jira/issue/IssueObjectFilter.java

Violation Line
No need to import a type that lives in the same package 3

com/atlassian/jira/issue/operations/ExtendedDeleteIssueOperation.java

Violation Line
Avoid unused imports such as 'com.atlassian.plugin.PluginManager' 11

com/atlassian/jira/issue/search/FilterFactory.java

Violation Line
Avoid unused imports such as 'org.ofbiz.core.entity.GenericEntityException' 5
Avoid unused imports such as 'com.atlassian.jira.issue.index.DocumentConstants' 8
Avoid unused imports such as 'com.atlassian.jira.issue.search.parameters.lucene.UserParameter' 9
Avoid unused imports such as 'com.opensymphony.user.User' 11

com/atlassian/jira/issue/search/FilterHelper.java

Violation Line
Avoid unused imports such as 'java.util.Collection' 3
Avoid unused imports such as 'java.util.Iterator' 4
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 6
Avoid unused imports such as 'org.ofbiz.core.entity.GenericEntityException' 9
Avoid unused imports such as 'org.ofbiz.core.entity.GenericValue' 10
Avoid unused imports such as 'uk.ltd.getahead.dwr.WebContextFactory' 12
Avoid unused imports such as 'webwork.action.ActionContext' 13
Avoid unused imports such as 'com.atlassian.seraph.auth.DefaultAuthenticator' 16
Avoid unused imports such as 'com.opensymphony.user.Group' 17
Avoid unused private fields such as 'log'. 32
Avoid unused private fields such as 'author'. 38

com/atlassian/jira/issue/search/parameters/filter/WorkedRetentionIssueFilter.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.issue.worklog.ExtendedWorklog' 14
Avoid unused private fields such as 'workerManager'. 31
Avoid empty if statements 71 - 74

com/atlassian/jira/issue/workers/DefaultWorkerManager.java

Violation Line
Avoid unused imports such as 'java.util.Date' 6
Avoid unused imports such as 'com.atlassian.jira.util.DateTools' 25
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 128
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 130

com/atlassian/jira/issue/worklog/WorklogAttributes.java

Violation Line
Avoid unused private fields such as 'groupLevel'. 48
Avoid unused private fields such as 'roleLevelId'. 50

com/atlassian/jira/issue/worklog/WorklogHelper.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.bc.JiraServiceContext' 40
Avoid unused imports such as 'com.atlassian.jira.project.Project' 53
Avoid unused imports such as 'com.atlassian.jira.security.JiraAuthenticationContext' 56
Avoid unused imports such as 'com.atlassian.seraph.auth.AuthenticationContext' 65
Avoid unused constructor parameters such as 'worklogStore'. 96 - 110
Avoid unused constructor parameters such as 'timeTrackingIssueUpdater'. 96 - 110
Avoid unused constructor parameters such as 'textAnalyzer'. 96 - 110
An empty statement (semicolon) not part of a loop 454
Avoid unused private methods such as 'getWorklogs(Map)'. 474
Avoid unused method parameters such as '_parameterHolder'. 474 - 517
Avoid unused local variables such as 'worklogActions'. 477
Ensure you override both equals() and hashCode() 697
These nested if statements could be combined 821 - 824
These nested if statements could be combined 828 - 833
These nested if statements could be combined 829 - 832
These nested if statements could be combined 837 - 839

com/atlassian/jira/jelly/tag/AddNotifiableFields.java

Violation Line
Avoid unused private fields such as 'log'. 25

com/atlassian/jira/jelly/tag/CreateParameter.java

Violation Line
Avoid unused private fields such as 'log'. 13

com/atlassian/jira/jelly/tag/issue/CreateSubTaskIssue.java

Violation Line
Avoid unused private fields such as 'log'. 25

com/atlassian/jira/jelly/tag/ValidationHelper.java

Violation Line
Avoid unused imports such as 'org.ofbiz.core.entity.GenericEntityException' 10
Avoid unused imports such as 'com.opensymphony.user.Group' 14
Avoid empty if statements 74 - 76

com/atlassian/jira/migrate/AbstractMigrateTask.java

Violation Line
Avoid unused imports such as 'org.ofbiz.core.entity.GenericEntityException' 12
Avoid unused imports such as 'com.atlassian.jira.ManagerFactory' 15

com/atlassian/jira/plugin/issueoperation/CreateAndLinkIssueOperation.java

Violation Line
Overriding method merely calls super 32 - 34

com/atlassian/jira/plugin/issueoperation/LinkerIssueOperationModuleDescriptor.java

Violation Line
Avoid unused imports such as 'java.util.Map' 4

com/atlassian/jira/plugin/issuetabpanel/WorklogTabPanel.java

Violation Line
Avoid unused imports such as 'com.atlassian.plugin.ModuleDescriptor' 31
Overriding method merely calls super 62 - 64

com/atlassian/jira/plugin/report/AbstractIssueBeanHelper.java

Violation Line
Avoid empty catch blocks 91 - 92

com/atlassian/jira/plugin/report/issue/AIssueReport.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.ComponentManager' 11
Avoid unused imports such as 'com.atlassian.jira.issue.worklog.WorklogHelper' 28

com/atlassian/jira/plugin/report/issue/IssueGroupData.java

Violation Line
Avoid empty if statements 17 - 19

com/atlassian/jira/plugin/report/provider/ReportElementOnCustomField.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.issue.customfields.impl.AbstractMultiSettableCFType' 17
Avoid unused private fields such as 'log'. 30
Avoid unused constructor parameters such as '_key'. 42 - 44

com/atlassian/jira/plugin/report/provider/ReportElementOnLinkedEntity.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.issue.IssueRelationConstants' 17

com/atlassian/jira/plugin/report/workload/AWorkloadNameTranslator.java

Violation Line
Avoid empty catch blocks 74 - 75

com/atlassian/jira/plugin/report/workload/AWorkloadReport.java

Violation Line
Avoid unnecessary return statements 160

com/atlassian/jira/plugin/report/workload/provider/WorkloadIssuePanelReportDefinitionProvider.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.plugin.report.provider.ReportElementOnComponent' 13
Avoid unused imports such as 'com.atlassian.jira.plugin.report.provider.ReportElementOnIssue' 15

com/atlassian/jira/plugin/report/workload/provider/WorkloadIssueReportDefinitionProvider.java

Violation Line
Avoid unused imports such as 'java.util.HashMap' 4
Avoid unused imports such as 'com.atlassian.jira.plugin.report.provider.ReportElementOnComponent' 14
Avoid unused imports such as 'com.atlassian.jira.plugin.report.provider.ReportElementOnIssue' 16
Avoid unused imports such as 'com.opensymphony.user.User' 17

com/atlassian/jira/plugin/report/workload/WorkloadHelper.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 344
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 345
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 351
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 356
Avoid unused local variables such as 'realField'. 389

com/atlassian/jira/portal/AnyProjectCategoryValuesGenerator.java

Violation Line
These nested if statements could be combined 62 - 64

com/atlassian/jira/portal/portlets/FastWorklogPortlet.java

Violation Line
Avoid unused imports such as 'java.util.Collection' 14
Avoid unused imports such as 'java.util.TreeMap' 21
Avoid unused private fields such as 'issueFactory'. 85
Avoid unused constructor parameters such as 'projectManager'. 92 - 106
Avoid unused constructor parameters such as 'constantsManager'. 92 - 106
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 163
Avoid unused private methods such as 'getWorkedIssues(User,long,String,boolean)'. 302

com/atlassian/jira/portal/portlets/FastWorklogPortletOnRequest.java

Violation Line
Avoid unused constructor parameters such as 'issueManager'. 44 - 51
Avoid unused constructor parameters such as 'projectManager'. 44 - 51

com/atlassian/jira/referentiel/entities/AInternalEntity.java

Violation Line
Avoid empty catch blocks 43 - 44
Avoid empty catch blocks 70 - 71

com/atlassian/jira/scheduler/JiraAddOnSchedulerLauncher.java

Violation Line
Overriding method merely calls super 14 - 16

com/atlassian/jira/service/services/export/RollOverExportService.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 111
Ensure you override both equals() and hashCode() 159

com/atlassian/jira/servlet/DWRServlet.java

Violation Line
Avoid unused imports such as 'com.atlassian.plugin.PluginManager' 38

com/atlassian/jira/upgrade/AAddOnUpgradeManager.java

Violation Line
No need to import a type that lives in the same package 38
No need to import a type that lives in the same package 39
No need to import a type that lives in the same package 40
Avoid unnecessary return statements 187

com/atlassian/jira/util/DateTools.java

Violation Line
Avoid unused imports such as 'electric.xml.ParseException' 22
Avoid unused local variables such as 't'. 308

com/atlassian/jira/util/entities/EntitiesHelper.java

Violation Line
Avoid unused private fields such as 'customFieldValidator'. 68
Avoid unused private fields such as 'fieldScreenManager'. 74
Avoid unused private fields such as 'fieldConfigSchemeManager'. 78
Avoid unnecessary return statements 220
Avoid empty finally blocks 325 - 326

com/atlassian/jira/util/entities/SequencedEntity.java

Violation Line
Avoid unused private fields such as 'sequence'. 15

com/atlassian/jira/util/RelativeDatetools.java

Violation Line
Avoid unused imports such as 'electric.xml.ParseException' 8
Avoid empty if statements 216 - 217
Avoid empty if statements 248 - 250

com/atlassian/jira/web/action/admin/entities/AbstractDeleteEntity.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.referentiel.entities.AInternalEntity' 26
Overriding method merely calls super 192 - 194

com/atlassian/jira/web/action/admin/entities/AbstractEntityBrowser.java

Violation Line
Overriding method merely calls super 196 - 198

com/atlassian/jira/web/action/admin/entities/AbstractViewEntity.java

Violation Line
Overriding method merely calls super 50 - 53
Overriding method merely calls super 83 - 85

com/atlassian/jira/web/action/admin/entities/Usage.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.referentiel.entities.AInternalEntity' 10

com/atlassian/jira/web/action/admin/link/scheme/AddScheme.java

Violation Line
Overriding method merely calls super 38 - 40

com/atlassian/jira/web/action/admin/link/scheme/CopyScheme.java

Violation Line
Overriding method merely calls super 38 - 40

com/atlassian/jira/web/action/admin/link/scheme/DeleteScheme.java

Violation Line
Overriding method merely calls super 39 - 41

com/atlassian/jira/web/action/admin/link/scheme/EditLinkSchemeEntities.java

Violation Line
Avoid empty if statements 89 - 90

com/atlassian/jira/web/action/admin/link/scheme/EditScheme.java

Violation Line
Overriding method merely calls super 39 - 41

com/atlassian/jira/web/action/admin/link/scheme/SchemeLinkAwareAction.java

Violation Line
Overriding method merely calls super 38 - 40

com/atlassian/jira/web/action/admin/link/scheme/SelectScheme.java

Violation Line
Overriding method merely calls super 41 - 43
Avoid empty catch blocks 57 - 58

com/atlassian/jira/web/action/admin/link/scheme/ViewSchemes.java

Violation Line
Overriding method merely calls super 40 - 42

com/atlassian/jira/web/action/admin/plugins/settings/ViewPluginsSettings.java

Violation Line
Overriding method merely calls super 42 - 44

com/atlassian/jira/web/action/admin/translation/ViewAddOnTranslations.java

Violation Line
Avoid unused imports such as 'java.util.ArrayList' 3
These nested if statements could be combined 48 - 50
These nested if statements could be combined 59 - 61
These nested if statements could be combined 69 - 71
These nested if statements could be combined 95 - 97

com/atlassian/jira/web/action/admin/user/UserGroupsPickerBrowser.java

Violation Line
Avoid unused imports such as 'com.atlassian.core.user.GroupUtils' 10

com/atlassian/jira/web/action/admin/worklogtypes/DeleteWorklogType.java

Violation Line
Do not use if statements that are always true or always false 119

com/atlassian/jira/web/action/issue/AReservedViewIssue.java

Violation Line
These nested if statements could be combined 59 - 62

com/atlassian/jira/web/action/issue/AViewIssue.java

Violation Line
These nested if statements could be combined 56 - 59

com/atlassian/jira/web/action/issue/CreateAndLinkIssue.java

Violation Line
Avoid unused imports such as 'java.util.Collection' 4
Avoid unused imports such as 'org.apache.commons.collections.CollectionUtils' 8
Avoid unused imports such as 'org.apache.commons.collections.ListUtils' 9
Avoid unused private fields such as 'linkCollection'. 43
Avoid unused constructor parameters such as 'issueLinkTypeManager'. 63 - 70
Avoid empty catch blocks 123 - 125
Avoid empty catch blocks 125 - 127

com/atlassian/jira/web/action/issue/EditIssueWorkLog.java

Violation Line
Avoid empty catch blocks 163 - 164
Overriding method merely calls super 280 - 282

com/atlassian/jira/web/action/issue/ExtendedCreateWorklog.java

Violation Line
Avoid unused local variables such as 'redirect'. 64

com/atlassian/jira/web/action/issue/ExtendedCreateWorklogForAjax.java

Violation Line
Avoid unused constructor parameters such as '_issueManager'. 30 - 46

com/atlassian/jira/web/action/issue/ExtendedDeleteWorklog.java

Violation Line
Avoid unused local variables such as 'redirect'. 65

com/atlassian/jira/web/action/issue/ExtendedDeleteWorklogForAjax.java

Violation Line
Avoid unused constructor parameters such as '_issueManager'. 23 - 27

com/atlassian/jira/web/action/issue/ExtendedUpdateWorklog.java

Violation Line
Avoid unused local variables such as 'redirect'. 54

com/atlassian/jira/web/action/issue/ExtendedUpdateWorklogForAjax.java

Violation Line
Avoid unused imports such as 'org.ofbiz.core.entity.GenericEntityException' 6
Avoid unused constructor parameters such as '_issueManager'. 27 - 31
Avoid unused constructor parameters such as '_workerManager'. 27 - 31

com/atlassian/jira/web/action/issue/HackedCreateWorklog.java

Violation Line
Overriding method merely calls super 28 - 31

com/atlassian/jira/web/action/issue/IssueLinkedCreationHelperBeanImpl.java

Violation Line
Avoid unused private fields such as 'log'. 39

com/atlassian/jira/web/action/issue/ManageWorkers.java

Violation Line
Overriding method merely calls super 50 - 52
Avoid empty catch blocks 82 - 83
Avoid empty catch blocks 83 - 84
Avoid empty catch blocks 97 - 98

com/atlassian/jira/web/dwr/AjaxManageableAsProjectPicker.java

Violation Line
Avoid unused private fields such as 'log'. 13

com/atlassian/jira/workflow/condition/ValidatingIssueCondition.java

Violation Line
Avoid empty catch blocks 24 - 25

com/atlassian/jira/workflow/ExtendedWorkflowManager.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 174

com/atlassian/jira/workflow/transition/AutoTransitionManager.java

Violation Line
Avoid unused imports such as 'com.atlassian.jira.issue.Issue' 6

com/atlassian/jira/workflow/transition/step/StepImpl.java

Violation Line
These nested if statements could be combined 60 - 62

com/atlassian/jira/workflow/validator/ResolutionCommentValidator.java

Violation Line
These nested if statements could be combined 56 - 59

com/atlassian/jira/workflow/WorkflowTransitionUtilAddOnImpl.java

Violation Line
These nested if statements could be combined 96 - 98

com/atlassian/servlet/CombinedServlet.java

Violation Line
Avoid unused private fields such as 'data'. 46
Avoid unused private fields such as 'cacheExpirationHandler'. 48

fr/kaamelot/reporter/AGroupData.java

Violation Line
Avoid unused private methods such as 'hasData()'. 131